RFR: 8377777: Improve logging when rejecting assets from the AOT archive [v4]
María Arias de Reyna Domínguez
duke at openjdk.org
Fri Feb 13 13:04:45 UTC 2026
On Fri, 13 Feb 2026 12:20:13 GMT, María Arias de Reyna Domínguez <duke at openjdk.org> wrote:
>> src/hotspot/share/oops/cpCache.cpp line 605:
>>
>>> 603:
>>> 604: if (!AOTConstantPoolResolver::is_resolution_deterministic(src_cp, cp_index)) {
>>> 605: if (log.is_enabled()) {
>>
>> This also needs to identify the method that has been linked via the CP entry. However, note that the linkage for field and indy entries is also checked and erased (in ConstantPoolCache methods `remove_resolved_field_entries_if_non_deterministic` and `remove_resolved_indy_entries_if_non_deterministic`) when `AOTConstantPoolResolver::is_resolution_deterministic` returns true. So, a log message should be added in those two cases but this time identifying the target field or target BSM.
>
> If I understand it right, for indy and for fields, the only reason (right now) to be rejected is because they are not deterministic.
>
> Is it worth an error message explaining that?
Added it anyway, but at least for now it feels a bit redundant to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29690#discussion_r2804099449
More information about the hotspot-dev
mailing list