RFR: 8370044: TraceBytecodes shouldn't break up lines [v2]

Paul Hübner phubner at openjdk.org
Mon Feb 23 09:13:47 UTC 2026


On Mon, 23 Feb 2026 00:03:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Paul Hübner has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Johan's feedback.
>
> src/hotspot/share/interpreter/bytecodeTracer.hpp line 41:
> 
>> 39: class BytecodeTracer: AllStatic {
>> 40:  public:
>> 41:   NOT_PRODUCT(static void trace_interpreter(const methodHandle& method, address bcp, uintptr_t tos, uintptr_t tos2, outputStream* st);)
> 
> Seems an unnecessary change.

While working with `BytecodeTracer` in general, I found it was difficult to keep track of what param is being passed where due to the many defaults, which we saw led to a lot of double buffering. I wanted to be more defensive and explicit with this function in case we have to extend it in the future, but I'm okay to revert the change if you like.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29842#discussion_r2839743436


More information about the hotspot-dev mailing list