RFR: 8370044: TraceBytecodes shouldn't break up lines [v2]
Coleen Phillimore
coleenp at openjdk.org
Mon Feb 23 18:15:22 UTC 2026
On Mon, 23 Feb 2026 09:07:37 GMT, Paul Hübner <phubner at openjdk.org> wrote:
>> src/hotspot/share/interpreter/bytecodeTracer.hpp line 41:
>>
>>> 39: class BytecodeTracer: AllStatic {
>>> 40: public:
>>> 41: NOT_PRODUCT(static void trace_interpreter(const methodHandle& method, address bcp, uintptr_t tos, uintptr_t tos2, outputStream* st);)
>>
>> Seems an unnecessary change.
>
> While working with `BytecodeTracer` in general, I found it was difficult to keep track of what param is being passed where due to the many defaults, which we saw led to a lot of double buffering. I wanted to be more defensive and explicit with this function in case we have to extend it in the future, but I'm okay to revert the change if you like.
oh no, please don't revert this. It's good to make all the callers pass the right thing, and in most cases, that should not be tty but some logging output stream.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29842#discussion_r2842269777
More information about the hotspot-dev
mailing list