RFR: 8370044: TraceBytecodes shouldn't break up lines [v2]
David Holmes
dholmes at openjdk.org
Tue Feb 24 04:53:53 UTC 2026
On Mon, 23 Feb 2026 17:55:18 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> While working with `BytecodeTracer` in general, I found it was difficult to keep track of what param is being passed where due to the many defaults, which we saw led to a lot of double buffering. I wanted to be more defensive and explicit with this function in case we have to extend it in the future, but I'm okay to revert the change if you like.
>
> oh no, please don't revert this. It's good to make all the callers pass the right thing, and in most cases, that should not be tty but some logging output stream.
Yeah - the days of "everything to tty by default" are behind us.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29842#discussion_r2844487073
More information about the hotspot-dev
mailing list