RFR: 8378675: PPC64: increase instruction cache line size [v3]
Richard Reingruber
rrich at openjdk.org
Thu Feb 26 15:55:52 UTC 2026
On Thu, 26 Feb 2026 13:23:04 GMT, David Briemann <dbriemann at openjdk.org> wrote:
>> Set the instruction cache line size for Power to 128 bytes.
>>
>> Add functions to retrieve the data cache line size and instruction cache line size from the system (AIX & Linux).
>
> David Briemann has updated the pull request incrementally with one additional commit since the last revision:
>
> remove comments, fix comparison
src/hotspot/share/runtime/os.hpp line 1080:
> 1078:
> 1079: static int get_dcache_line_size();
> 1080: static int get_icache_line_size();
There seems to be an inconsistency: besides these declarations there are also (unused) declarations in os::Linux and os::Aix. The definitions and references, though, are for these declarations (in class os). Problem with the declarations in os is that not all OSes have implementations.
I think this needs to be resolved.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29918#discussion_r2859822843
More information about the hotspot-dev
mailing list