RFR: 8378675: PPC64: increase instruction cache line size [v3]
Martin Doerr
mdoerr at openjdk.org
Thu Feb 26 16:17:02 UTC 2026
On Thu, 26 Feb 2026 15:52:28 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> David Briemann has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove comments, fix comparison
>
> src/hotspot/share/runtime/os.hpp line 1080:
>
>> 1078:
>> 1079: static int get_dcache_line_size();
>> 1080: static int get_icache_line_size();
>
> There seems to be an inconsistency: besides these declarations there are also (unused) declarations in os::Linux and os::Aix. The definitions and references, though, are for these declarations (in class os). Problem with the declarations in os is that not all OSes have implementations.
> I think this needs to be resolved.
Doesn't this work as designed? `cpu_microcode_revision()` doesn't have implementations for all platforms, either. The 2 new functions can be implemented on more OSes on demand.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29918#discussion_r2859943281
More information about the hotspot-dev
mailing list