RFR: 8372040: Remove Prefetch header vs inline header separation
Stefan Karlsson
stefank at openjdk.org
Fri Jan 9 09:05:27 UTC 2026
On Thu, 8 Jan 2026 19:55:38 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Given the OS_CPU_HEADER_INLINE files are not intended to be included directly by anything except their shared counterpart, I think it looks very odd to write it as-if we expect it to be included directly. To me the comment, per orderAccess files suffices if this is a concern.
I somewhat agree. With a comment this helps readers enough.
The following is an explanation why I still think this is a bit unfortunate (but not enough to push further against this change):
IDEs don't always understand what's going. Another drawback is that you now can't compile the file stand-alone. That's not a problem for day-to-day building HotSpot, but for those of us that often clean out warnings in HotSpot, this makes it a tad bit more annoying when you can't compile the .hpp stand-alone. I compile .hpp files quite often. OTOH, I personally know enough of the HotSpot include systems so I'll compile prefetch.inline.hpp instead.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29096#issuecomment-3727906836
More information about the hotspot-dev
mailing list