RFR: 8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics [v3]
Manuel Hässig
mhaessig at openjdk.org
Wed Jan 21 12:54:30 UTC 2026
On Wed, 21 Jan 2026 12:32:12 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/arguments/TestUseSHA3IntrinsicsWithUseSHADisabled.java line 32:
>>
>>> 30: * @requires vm.flagless
>>> 31: * @requires os.arch == "amd64" | os.arch == "x86_64"
>>> 32: * @requires vm.cpu.features ~= ".*avx512f.*" & vm.cpu.features ~= ".*avx512bw.*"
>>
>> It would be great to also test that the warning is emitted when `-XX:+UseSHA3Intrinsics` is passed, but is not supported by the CPU. You could remove this line and detect the features using `WHITE_BOX.getCPUFeatures()`.
>
> the properties are set already using WhiteBox.getCPUFeatures()
> https://github.com/openjdk/jdk/blob/983ae96f60c935aa52f482d21ae6a0d947679541/test/lib/jdk/test/whitebox/cpuinfo/CPUInfo.java#L53C39-L53C53
Right. But ideally, the test would not only run on machines where AVX512 is supported and check the warning on unsupported machines for complete coverage of the flag handling.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29266#discussion_r2712429391
More information about the hotspot-dev
mailing list