RFR: 8375443: AVX-512: Disabling through UseSHA doesn't affect UseSHA3Intrinsics [v3]
Manuel Hässig
mhaessig at openjdk.org
Wed Jan 21 12:54:30 UTC 2026
On Wed, 21 Jan 2026 12:47:28 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
>> the properties are set already using WhiteBox.getCPUFeatures()
>> https://github.com/openjdk/jdk/blob/983ae96f60c935aa52f482d21ae6a0d947679541/test/lib/jdk/test/whitebox/cpuinfo/CPUInfo.java#L53C39-L53C53
>
> Right. But ideally, the test would not only run on machines where AVX512 is supported and check the warning on unsupported machines for complete coverage of the flag handling.
So, if you remove the `@requires` you can then use `CPUInfo` to check if the machine the test is running on has the required CPU features and add a new test case for when a machine does not.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29266#discussion_r2712441716
More information about the hotspot-dev
mailing list