RFR: 8372652: Re-enable LocalRandom clinit after monitor pinning improvements

Alan Bateman alanb at openjdk.org
Sat Jan 24 08:54:58 UTC 2026


On Mon, 1 Dec 2025 22:38:29 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>>> Unfortunately, there are might be failure of execution `vmTestbase/`with `JTREG_TEST_THREAD_FACTORY=Virtual`. So it enough ensure the your fix doesn't create new failures and timeouts
>> 
>> I am trying to parse this :) So, if `make test TEST=vmTestbase/ JTREG=TEST_THREAD_FACTORY=Virtual` passes, we are good to go, correct?
>
>> > Unfortunately, there are might be failure of execution `vmTestbase/`with `JTREG_TEST_THREAD_FACTORY=Virtual`. So it enough ensure the your fix doesn't create new failures and timeouts
>> 
>> I am trying to parse this :) So, if `make test TEST=vmTestbase/ JTREG=TEST_THREAD_FACTORY=Virtual` passes, we are good to go, correct?
> 
> Sure.
> I meant that we don't run whole vmTestbase with TEST_THREAD_FACTORY=Virtual, so I am unsure if there are some failures exist now.

> @lmesnik @AlanBateman A gentle reminder for the review.

I don't have anything to add. As Patricio's said in one of the messages, the "TODO" comment may not have been accurate. If the tests runs are good then it should be okay.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28547#issuecomment-3794251381


More information about the hotspot-dev mailing list