RFR: 8372652: Re-enable LocalRandom clinit after monitor pinning improvements
Vishal Chand
duke at openjdk.org
Sat Jan 24 10:34:56 UTC 2026
On Sat, 24 Jan 2026 08:52:08 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>>> > Unfortunately, there are might be failure of execution `vmTestbase/`with `JTREG_TEST_THREAD_FACTORY=Virtual`. So it enough ensure the your fix doesn't create new failures and timeouts
>>>
>>> I am trying to parse this :) So, if `make test TEST=vmTestbase/ JTREG=TEST_THREAD_FACTORY=Virtual` passes, we are good to go, correct?
>>
>> Sure.
>> I meant that we don't run whole vmTestbase with TEST_THREAD_FACTORY=Virtual, so I am unsure if there are some failures exist now.
>
>> @lmesnik @AlanBateman A gentle reminder for the review.
>
> I don't have anything to add. As Patricio's said in one of the messages, the "TODO" comment may not have been accurate. If the tests runs are good then it should be okay.
@AlanBateman I confirmed that the test runs are fine [in this comment](https://github.com/openjdk/jdk/pull/28547#issuecomment-3675825598).
I think Aleksey is waiting for your approval.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28547#issuecomment-3794430680
More information about the hotspot-dev
mailing list