RFR: 8353564: Fail fatally if os::release_memory or os::uncommit_memory fails [v4]

[Thomas Stuefe]

On Wed, 28 Jan 2026 02:13:20 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make remove_stack_guard_pages return void
>
> src/hotspot/os/bsd/os_bsd.cpp line 1766:
> 
>> 1764: // If this is a growable mapping, remove the guard pages entirely by
>> 1765: // munmap()ping them.  If not, just call uncommit_memory().
>> 1766: void os::remove_stack_guard_pages(char* addr, size_t size) {
> 
> Pre-existing but the method comment seems out-of-sync with the implementation.

Yes, this only applies to Linux and its primordial stack segment. Maybe the whole function was copied over from Linux, including comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29240#discussion_r2735298210