RFR: 8353564: Fail fatally if os::release_memory or os::uncommit_memory fails [v4]

Robert Toyonaga duke at openjdk.org
Wed Jan 28 21:24:35 UTC 2026


On Wed, 28 Jan 2026 07:50:14 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/os/bsd/os_bsd.cpp line 1766:
>> 
>>> 1764: // If this is a growable mapping, remove the guard pages entirely by
>>> 1765: // munmap()ping them.  If not, just call uncommit_memory().
>>> 1766: void os::remove_stack_guard_pages(char* addr, size_t size) {
>> 
>> Pre-existing but the method comment seems out-of-sync with the implementation.
>
> Yes, this only applies to Linux and its primordial stack segment. Maybe the whole function was copied over from Linux, including comment.

I've removed this comment now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29240#discussion_r2738654525


More information about the hotspot-dev mailing list