RFR: 8353564: Fail fatally if os::release_memory or os::uncommit_memory fails [v4]

[Robert Toyonaga]

On Wed, 28 Jan 2026 02:15:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Robert Toyonaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   make remove_stack_guard_pages return void
>
> src/hotspot/os/bsd/os_bsd.cpp line 1767:
> 
>> 1765: // munmap()ping them.  If not, just call uncommit_memory().
>> 1766: void os::remove_stack_guard_pages(char* addr, size_t size) {
>> 1767:   os::uncommit_memory(addr, size, false);
> 
> Why are you explicitly passing false now (here and in most other places below) instead of utilising the default argument?
> 
> If you want to make this explicit then it would be helpful to comment what the `false` means:  `false /* not executable */)`

This was left over from when I was previously passing error strings. I agree we should instead be relying on the default argument.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29240#discussion_r2738666163