"Disabling Explicit GC" message in gc log with G1 collector

[Tony Printezis]

PS This is the culprit, right?

--- a/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
+++ b/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
@@ -912,11 +912,6 @@
     Universe::print_heap_before_gc();
   }
 
-  if (full && DisableExplicitGC) {
-    gclog_or_tty->print("\n\n\nDisabling Explicit GC\n\n\n");
-    return;
-  }
-
   assert(SafepointSynchronize::is_at_safepoint(), "should be at 
safepoint");
   assert(Thread::current() == VMThread::vm_thread(), "should be in vm 
thread");
 


Tony Printezis wrote:
> Andreas,
>
> Thanks for bringing this up. It's most likely debugging code that we 
> accidentally failed to remove. Apologies. I'll  remove it piggy-backed 
> on my next push.
>
> Tony
>
> Andreas Kohn wrote:
>> Hi,
>>
>> while playing with the G1 collector I noticed that our gc logs are now
>> filled with a "Disabling Explicit GC" message repeating quite often.
>>
>> This seems to be coming from g1CollectedHeap.cpp
>> G1CollectedHeap::do_collection().
>>
>> We have -XX:+DisableExplicitGC and -Xloggc enabled by default, so in a
>> way this is pretty much expected.
>> I've now removed the print statement there, so that the gc log becomes a
>> bit more readable. Was there a reason that G1 logs this condition?
>> Regards,
>> -- 
>> Andreas
>>
>>