"Disabling Explicit GC" message in gc log with G1 collector

[Andreas Kohn]

On Wed, 2010-04-14 at 15:25 -0400, Tony Printezis wrote:
> PS This is the culprit, right?

Yes. I wasn't sure whether the return there is important, so locally i
only killed the print() to be safe :)

Thanks for picking this up!

--
Andreas

> 
> --- a/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
> +++ b/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
> @@ -912,11 +912,6 @@
>      Universe::print_heap_before_gc();
>    }
>  
> -  if (full && DisableExplicitGC) {
> -    gclog_or_tty->print("\n\n\nDisabling Explicit GC\n\n\n");
> -    return;
> -  }
> -
>    assert(SafepointSynchronize::is_at_safepoint(), "should be at 
> safepoint");
>    assert(Thread::current() == VMThread::vm_thread(), "should be in vm 
> thread");
>  
> 
> 
> Tony Printezis wrote:
> > Andreas,
> >
> > Thanks for bringing this up. It's most likely debugging code that we 
> > accidentally failed to remove. Apologies. I'll  remove it piggy-backed 
> > on my next push.
> >
> > Tony
> >
> > Andreas Kohn wrote:
> >> Hi,
> >>
> >> while playing with the G1 collector I noticed that our gc logs are now
> >> filled with a "Disabling Explicit GC" message repeating quite often.
> >>
> >> This seems to be coming from g1CollectedHeap.cpp
> >> G1CollectedHeap::do_collection().
> >>
> >> We have -XX:+DisableExplicitGC and -Xloggc enabled by default, so in a
> >> way this is pretty much expected.
> >> I've now removed the print statement there, so that the gc log becomes a
> >> bit more readable. Was there a reason that G1 logs this condition?
> >> Regards,
> >> -- 
> >> Andreas
> >>
> >>   

-- 
Never attribute to malice that which can be adequately explained by
stupidity.                                        -- Hanlon's Razor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20100414/08917126/signature.asc>