Request for review (XS): 7036482: clear argument is redundant and unused in cardtable methods

John Coomes John.Coomes at oracle.com
Thu Apr 14 08:10:42 UTC 2011


Y. S. Ramakrishna (y.s.ramakrishna at oracle.com) wrote:
> 
> 7036482: clear argument is redundant and unused in cardtable methods
> 
> http://cr.openjdk.java.net/~ysr/7036482/webrev.00/

The change in allocationStats.hpp is unrelated, is it intended for
this fix?  Aside from that, looks good to me.

> As in synopsis; further motivational detail may be found
> in the CR. Some further cleanups/deletions will follow in
> subsequent CR's to be filed.

mod_oop_in_space_iterate(), the only method that calls
non_clean_card_iterate() with clear != false, is unused.  Is deleting
it one of the further cleanups?  Removing it makes it easier to see
that 'clear' is not needed, so you could include it with this change.

-John



More information about the hotspot-gc-dev mailing list