Request for review (XXS): 7193157: G1: Make some develpflags available in product builds

Vitaly Davidovich vitalyd at gmail.com
Wed Aug 22 12:27:07 UTC 2012


Looks good.  One small typo:

experimental(uintx, G1OldCSetRegionLiveThresholdPercent, 90,

"Threshold for regions to be added to the collection set. "

"Regions with more live bytes that this will not be collected.")

The "that this" should be "than this".

Cheers

Sent from my phone
On Aug 22, 2012 3:50 AM, "Bengt Rutisson" <bengt.rutisson at oracle.com> wrote:

>
> Hi all,
>
> Could I please have a couple of reviews for this really small fix?
> http://cr.openjdk.java.net/~**brutisso/7193157/webrev.00/<http://cr.openjdk.java.net/~brutisso/7193157/webrev.00/>
>
> We need to make some of the G1 develop flags available in product builds
> to allow the performance team to tune G1 properly. We decided to make the
> flags experimental to start with. After the performance team has evaluated
> the flags we might make some of them product flags. The current prime
> candidates for becoming product flags are:
>
> G1DefaultMinNewGenPercent
> G1DefaultMaxNewGenPercent
> G1OldCSetRegionLiveThresholdPe**rcent
>
> Thanks,
> Bengt
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20120822/417e346c/attachment.htm>


More information about the hotspot-gc-dev mailing list