review request (XS) - 7112413: disable AdaptiveSizePolicy w/CMS

[Bengt Rutisson]

John,

Inline.

On 2012-01-26 01:32, John Coomes wrote:
> Bengt Rutisson (bengt.rutisson at oracle.com) wrote:
>> Hi John,
>>
>> Looks good.
>>
>> One minor comment:
>>
>> I'd prefer the test:
>>
>> 1045     if (!FLAG_IS_DEFAULT(UseAdaptiveSizePolicy)) {
>>
>> to be:
>>
>> 1045     if (FLAG_IS_CMDLINE(UseAdaptiveSizePolicy)) {
>>
>> I think users are only interested in the warning if they actually had
>> the switch on the command line. If hotspot turns on the flag
>> ergonomically I think it is just confusing to customers to see the warning.
> Thanks for the review.  I'll make that change; it's more future-proof.

Great!

>> And a nit: copyright year should be 2012 ;-)
> Will fix that too.

:-)

>
>> Finally, a question that is not directly related to your change now. But
>> what is the plan for CMS and UseAdaptiveSizePolicy? Do we plan on fixing
>> it or should we just remove it? If the latter is the case, is there a CR
>> to remove it? With your change there is quite a few lines of code that
>> are essentially dead now.
> I think this is a longer-term discussion, tied to the future of CMS.
> Good topic for a future meeting :-).

I agree. We should include this topic when we discuss the GC technical 
roadmap.

Ship it!
Bengt
>
> -John
>
>> On 2012-01-25 06:26, John Coomes wrote:
>>> I'd appreciate reviews of a simple change to disable
>>> AdaptiveSizePolicy with CMS and/or ParNew, even if it has been enabled
>>> on the command line.
>>>
>>> http://cr.openjdk.java.net/~jcoomes/7112413-cms-adaptive
>>>
>>> -John