review request (XS) - 7112413: disable AdaptiveSizePolicy w/CMS

[Krystal Mok]

Hi John,

Comments inline:

On Thu, Jan 26, 2012 at 8:32 AM, John Coomes <John.Coomes at oracle.com> wrote:

> Bengt Rutisson (bengt.rutisson at oracle.com) wrote:
> >
> > Hi John,
> >
> > Looks good.
> >
> > One minor comment:
> >
> > I'd prefer the test:
> >
> > 1045     if (!FLAG_IS_DEFAULT(UseAdaptiveSizePolicy)) {
> >
> > to be:
> >
> > 1045     if (FLAG_IS_CMDLINE(UseAdaptiveSizePolicy)) {
> >
> > I think users are only interested in the warning if they actually had
> > the switch on the command line. If hotspot turns on the flag
> > ergonomically I think it is just confusing to customers to see the
> warning.
>
> Thanks for the review.  I'll make that change; it's more future-proof.
>
> Just a nitpick: the FLAG_IS_CMDLINE doesn't cover VM arguments that were
set from a config file (.hotspotrc), whose origin would have been
CONFIG_FILE.

It's nicer if there's a FLAG_IS_USER_SET or something, that covers all
cases where the argument might be set by a user instead of ergo.

- Kris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20120130/fdad80a8/attachment.htm>