RFR(S/M): 7127708: G1: change task num types from int to uint in concurrent mark

[John Cuthbertson]

Hi Vitaly,

Good catch - and you are correct. Changed.

JohnC

On 10/02/12 17:33, Vitaly Davidovich wrote:
>
> Hi John,
>
> concurrentMark.cpp:
>
> 4118     if (_cm->verbose_low()) {
> 4119       gclog_or_tty->print_cr("[%d] starting termination 
> protocol", _worker_id);
> 4120     }
>
> Should be %u format? Same in g1OopClosuresg1OopClosures.inline.hpp:
> if (_cm->verbose_high()) {
> 114     gclog_or_tty->print_cr("[%d] we're looking at location "
> 115                            "*"PTR_FORMAT" = "PTR_FORMAT,
> 116                            _task->worker_id(), p, (void*) obj);
> 117   }
>
> Thanks
>
> Sent from my phone
>
> On Oct 2, 2012 5:54 PM, "John Cuthbertson" 
> <john.cuthbertson at oracle.com <mailto:john.cuthbertson at oracle.com>> wrote:
>
>     Hi Everyone,
>
>     Can I have another couple of volunteers review the changes for
>     this CR - the webrev can be found at:
>     http://cr.openjdk.java.net/~johnc/7127708/webrev.0/
>     <http://cr.openjdk.java.net/%7Ejohnc/7127708/webrev.0/>
>
>     Summary:
>     Exactly what it says the the CR's description:
>
>         In G1's concurrent mark files we use an int for the task ID
>         and call it "task num". Recent work done by Jon Masamitsu:
>
>         7121618: Change type of number of GC workers to unsigned int
>
>         has replaced int's with uint's for the worker IDs across our
>         GCs. We should also make the necessary changes in the G1 files
>         to further conform to that. While we're at it we should also
>         rename "task num" as "worker id" to be consistent with the
>         rest of the GCs.
>
>
>
>     The changes were contributed by Kaushik Srenevasan from Twitter.
>     I've looked them over and they look OK to me.
>
>     Testing: jtreg tests and specjvm (Kaushik); GC test suite with a
>     low IHOP and marking verification (JohnC); a jprt test run is in
>     the queue.
>
>     Thanks,
>
>     JohnC
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20121003/05538b3f/attachment.htm>