RFR (S): 8006088: Incompatible heap size flags accepted by VM

Leonid Mesnik leonid.mesnik at oracle.com
Tue Apr 30 11:57:00 UTC 2013


There are a couple of comments to your test:
1)You added "test.java.opts" to tested process. Could external options 
break tests?
It think it is needed to ignore any heap and GC sensitive options which 
could affect your tests.


2) Does it make a sense to create separate method which create java with 
enables WhiteBox?
This method could be used in a lot of tests.

Leonid

On 04/30/2013 02:51 PM, Thomas Schatzl wrote:
> Hi all,
>
>    please review the latest changes for this CR, taking jtreg naming
> conventions into account.
>
> Differences:
>   - moved tests into different directory to conform to the new jtreg
> naming conventions
>   - updated to latest hotspot-gc (applied cleanly, no changes)
>
> @Tao: I added you to the reviewed-by set for this change. I hope this is
> okay with you as you apparently reviewed the previous version already.
>
> Ergonomics behavior reference:
> http://cr.openjdk.java.net/~tschatzl/8006088/webrev.6/XmsInitialHeapSizeErgo.html
>
> Bugs.sun.com:
> http://bugs.sun.com/view_bug.do?bug_id=8006088
>
> JIRA:
> https://jbs.oracle.com/bugs/browse/JDK-8006088
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8006088/webrev.8/
>
> Testing:
> JPRT, manual testing
>
> Thanks,
> Thomas
>
>


-- 
Leonid Mesnik
JVM SQE




More information about the hotspot-gc-dev mailing list