RFR (S): 8006088: Incompatible heap size flags accepted by VM

[Thomas Schatzl]

Hi Leonid,

  thanks for taking the time to review.

On Tue, 2013-04-30 at 15:57 +0400, Leonid Mesnik wrote:
> There are a couple of comments to your test:
> 1)You added "test.java.opts" to tested process. Could external options 
> break tests?
> It think it is needed to ignore any heap and GC sensitive options which 
> could affect your tests.

You mean when invoking the process that calls the whitebox api function
in TestMaxHeapSizeTools.getMinInitialMaxHeap()?

Admittedly this particular code was mostly copy and pasted from other
examples without actually knowing what it does at that time.

In this case, if test.java.opts contains the original test invocation
options, I think it is okay to actually ignore them here. I will remove
that.

> 2) Does it make a sense to create separate method which create java with 
> enables WhiteBox?
>This method could be used in a lot of tests.

I agree. I extracted the invocation into a separate method for now. Can
I move that refactoring to a separate CR? Next to this functionality,
there are other methods that may be reused in other test cases.
Particularly about argument parsing.

I will provide a new webrev shortly.

Thanks,
  Thomas