RFR(XS): 8005875: G1: Kitchensink fails with ParallelGCThreads=0

[Bengt Rutisson]

Hi John,

Thanks for doing this change. Looks much nicer!

Ship it!
Bengt

On 1/31/13 11:08 PM, John Cuthbertson wrote:
> Hi Everyone,
>
> Here's a new webrev based upon feedback from Vitaly and Bengt: 
> http://cr.openjdk.java.net/~johnc/8005875/webrev.1/
>
> I've wrapped the check with the asserts suggested by Bengt into a 
> small routine.
>
> Testing:
> GC test suite with ConcGCThreads=3
> Kitchensink with ParallelGCThreads=0:
>
> Thanks,
>
> JohnC
>
> On 1/8/2013 2:13 PM, John Cuthbertson wrote:
>> Hi Everyone,
>>
>> Can I please have a couple of volunteers look over the fix for this 
>> CR - the webrev can be found at: 
>> http://cr.openjdk.java.net/~johnc/8005875/webrev.0/
>>
>> Summary:
>> One of the modules in the Kitchensink test generates a 
>> VM_PrintThreads vm operation. The JVM crashes when it tries to print 
>> out G1's concurrent marking worker threads when ParallelGCThreads=0 
>> because the work gang has not been created. The fix is to add the 
>> same check that's used elsewhere in G1's concurrent marking.
>>
>> Testing:
>> Kitchensink with ParallelGCThreads=0
>>
>> Thanks,
>>
>> JohnC
>