int vs. uint for worker id [Was: Re: CMS parallel initial mark]

[Thomas Schatzl]

Hi again,

On Fri, 2013-06-07 at 23:47 +0200, Thomas Schatzl wrote:
> Hi,
> 
> On Fri, 2013-06-07 at 11:51 -0700, Hiroshi Yamauchi wrote:
> > 
> >          - I think Jon already mentioned that it might be better to
> >         use an int
> >         for worker_id in CMSParMarkTask::do_young_space_rescan() (if
> >         it is
> >         actually needed) to keep that code in line with current use.
> > 
> > 
> > I thought there was a mass conversion from "work(int i)" to "work(uint
> > worker_id)" around Hotspot 24 or so. Given that understanding, this
> > sounds like going backwards from uint to int. Am I misunderstanding?
> 
> No, you are right - when checking that statement I happened to look at
> exactly the files where for some reason this apparently not been changed
> - i.e. concurrentG1RefineThread.?pp and concurrentG1Refine.cpp. :(

Fyi, the original changed happened in CR 7121618
( http://bugs.sun.com/view_bug.do?bug_id=7121618 )

I added a new CR "8016302 Change type of the number of GC workers to
unsigned int (2)" to track that.

Thomas