RFR (S): JDK-6991197 G1: specialize deal_with_reference() for narrowOop*

Thomas Schatzl thomas.schatzl at oracle.com
Mon Jan 27 15:04:00 UTC 2014


Hi,

On Mon, 2014-01-27 at 14:15 +0100, Stefan Karlsson wrote:
> Thomas,
> 
> On 2014-01-27 12:51, Thomas Schatzl wrote:
> > Hi all,
> >
> > As I have the change on hand (I had to do it anyway for measurements) I
> > would like to ask your opinion whether to keep it or not. If so, ask for
> > review.
> >
> > I am actually undecided - personally I tend to like it (as it trims fat)
> > and it seems small enough to keep it and does not distract too much, but
> > it does not really show up on measurements.
> >
> > Testing:
> > jprt, specjbb2005/13, specjvm98/2008, CRM Fuse
> >
> > Bug entry:
> > https://bugs.openjdk.java.net/browse/JDK-6991197
> >
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/6991197/webrev/
> 
> Have you considered specializing has_partial_array_mask() to always 
> return false when T = narrowOop? If you do it that way, you would get 
> rid of the code duplication.

  that looks like a good idea, I will try that. Thanks.

Thomas





More information about the hotspot-gc-dev mailing list