RFR (S): (7u60,8u20,9) 8032771 Need test to cover JDK-8013132

Bengt Rutisson bengt.rutisson at oracle.com
Tue Jan 28 09:43:52 UTC 2014


Hi Thomas,

Looks good. Two minor nits:

The copyright year is 2013.

The method printJavaOpts() seems to provide useful information. Maybe it 
should be part of ProcessTools.createJavaProcessBuilder()?

Thanks,
Bengt


On 2014-01-27 16:51, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for the following small change? It adds a unit test
> for the VerifySilently option.
>
> This has been asked for by sqe while looking at the recent nmethod
> backport, so it should go all the way down to 7u60 (it is missing in all
> versions).
>
> It is the same webrev for all versions, as it just adds the missing
> regression test, so I am asking for reviews for versions at once. :)
>
> The test simply spawns a VM that is checked for the verification
> messages. When VerifySilently is enabled, there should be no messages at
> all, otherwise there should be.
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8032771/webrev/
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8032771
>
> Testing:
> local jtreg, jprt with jtreg test
>
> Thanks,
> Thomas
>
>
>




More information about the hotspot-gc-dev mailing list