RFR (S): (7u60,8u20,9) 8032771 Need test to cover JDK-8013132

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jan 28 10:38:04 UTC 2014


Hi Bengt,

  thanks for the review.

On Tue, 2014-01-28 at 10:43 +0100, Bengt Rutisson wrote:
> Hi Thomas,
> 
> Looks good. Two minor nits:
> 
> The copyright year is 2013.

Fixed.

> 
> The method printJavaOpts() seems to provide useful information. Maybe it 
> should be part of ProcessTools.createJavaProcessBuilder()?

I removed the method and all related references. This functionality is
already provided by ProcessTools.createJavaProcessBuilder().

It got introduced by me basing this patch from
TestVerifyDuringStartup.java, and then refactoring.

Not sure why the original code contains this additional printout.

New webrev:
http://cr.openjdk.java.net/~tschatzl/8032771/webrev.1

Thomas




More information about the hotspot-gc-dev mailing list