review request (S): 8057623: extension class for argument handling

Thomas Schatzl thomas.schatzl at oracle.com
Fri Sep 5 11:36:47 UTC 2014


Hi,

On Thu, 2014-09-04 at 18:03 -0700, John Coomes wrote:
> Hi,
> 
> Please review this change to add an extension class for argument
> handling:
> 
> http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057623-arguments-ext/
> 
> It's intended to allow easier customization of consistency checks and
> ergonomic gc selection.
> 

  looks good except for the odd indentation of the
check_gc_consistency_user() method.

Should we now indent all methods by all possible? And is
check_gc_consistency_ergo() performance critical so that it needs to be
inlined?

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list