review request (S): 8057623: extension class for argument handling

[John Coomes]

Thomas Schatzl (thomas.schatzl at oracle.com) wrote:
> Hi,
> 
> On Thu, 2014-09-04 at 18:03 -0700, John Coomes wrote:
> > Hi,
> > 
> > Please review this change to add an extension class for argument
> > handling:
> > 
> > http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057623-arguments-ext/
> > 
> > It's intended to allow easier customization of consistency checks and
> > ergonomic gc selection.
> > 
> 
>   looks good except for the odd indentation of the
> check_gc_consistency_user() method.
> 
> Should we now indent all methods by all possible? And is
> check_gc_consistency_ergo() performance critical so that it needs to be
> inlined?


Hi Thomas,

Thanks for reviewing it.  I just lined up the decl of
check_gc_consistency_user() method with check_gc_consistency_ergo()
immediately below it.  But there isn't consistency :-) in the
indentation, so I've changed it to just a single space.

check_gc_consistency_ergo() is not performance critical, but it is so
trivial inlining made sense (at least to me).

-John