review request (S) - 8057824 methods to copy allocation context stats

Thomas Schatzl thomas.schatzl at oracle.com
Wed Sep 10 08:04:47 UTC 2014


Hi,

On Tue, 2014-09-09 at 00:21 -0700, John Coomes wrote:
> Hi,
> 
> Please review this interface for copying allocation context statistics
> to native or java arrays.
> 
> http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057824-stats-copy/
> 

  some comments:

- in the declarations of the copy_allocation_context_stats() methods
please put every parameter on a single line.

- please give a description of the method, it seems to be non-obvious. I
assume that the passed "len" indicates the number of
contexts/totals/accuracies that are passed.

- spaces before the "*", which is unusual

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list