review request (S) - 8057824 methods to copy allocation context stats

[John Coomes]

Thomas Schatzl (thomas.schatzl at oracle.com) wrote:
> Hi,
> 
> On Tue, 2014-09-09 at 00:21 -0700, John Coomes wrote:
> > Hi,
> > 
> > Please review this interface for copying allocation context statistics
> > to native or java arrays.
> > 
> > http://cr.openjdk.java.net/~jcoomes/8u/8u40/8057824-stats-copy/
> > 
> 
>   some comments:
> 
> - in the declarations of the copy_allocation_context_stats() methods
> please put every parameter on a single line.

Fixed.

> - please give a description of the method, it seems to be non-obvious. I
> assume that the passed "len" indicates the number of
> contexts/totals/accuracies that are passed.

I added this comment:

  // Copy the current allocation context statistics for the specified contexts.
  // For each context in contexts, set the corresponding entries in the totals
  // and accuracy arrays to the current values held by the statistics.  Each
  // array should be of length len.
  virtual void copy_allocation_context_stats(const jint* contexts,
                                             jlong* totals,
                                             jbyte* accuracy,
                                             jint len) { }
 
> - spaces before the "*", which is unusual

Sure, fixed.

Thanks for looking at it.

-John