RFR (XS): JDK-8058534: Remove HeapRegion::_orig_end

Tony Printezis tprintezis at twitter.com
Thu Sep 18 23:18:26 UTC 2014


Joe,

Looks good, and +1 to Kim's suggestion below re: moving the comment for 
_orig_end to orig_end().

Tony

On 9/18/14, 6:24 PM, Kim Barrett wrote:
> On Sep 18, 2014, at 4:32 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
>> Can I have reviews for the following small change that removes the
>> _orig_end member from the HeapRegion class. The information this member
>> stores can be easily recalculated on the fly, so it is just a waste of a
>> few bytes.
>>
>> CR:https://bugs.openjdk.java.net/browse/JDK-8058534
>>
>> Webrev:http://cr.openjdk.java.net/~jprovino/8058534/webrev.00/
>>
>> Testing: jprt
> In the original code, the _orig_end member that is being removed had a descriptive
> comment.  That description no longer exists in the changed code.  Maybe that
> comment should be moved to the orig_end() accessor?
>
> Otherwise looks good.
>

-- 
Tony Printezis | JVM/GC Engineer / VM Team | Twitter

@TonyPrintezis
tprintezis at twitter.com




More information about the hotspot-gc-dev mailing list