RFR (XS): JDK-8058534: Remove HeapRegion::_orig_end

[Bengt Rutisson]

Hi,

On 9/19/14 9:28 AM, Thomas Schatzl wrote:
> Hi,
>
> On Fri, 2014-09-19 at 09:20 +0200, Bengt Rutisson wrote:
>> Hi Joe,
>>
>> Latest webrev looks good to me.
>>
>> I can sponsor this and push it through JPRT. I'll fix Kim's comment
>> about the missing space before I push. Nice catch, Kim!
>    can you fix the indentation of the error message too before pushing?
> I.e. align the arguments to the opening bracket?

Yes, thanks for finding that. Fixed the alignemnt too.

Here's what got pushed:
http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/rev/c919a19a9d9c

Thanks,
Bengt

>
> Thanks,
>    Thomas
>
>> Bengt
>>
>> On 9/19/14 1:25 AM, Kim Barrett wrote:
>>> On Sep 18, 2014, at 6:43 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
>>>> Kim, thanks.  I made that change you suggested.
>>>>
>>>> Webrev:  http://cr.openjdk.java.net/~jprovino/8058534/webrev.01/
>>> Sorry, I missed some problems with the assert message added in HeapRegion::initialize()
>>> gc_implementation/g1/heapRegion.cpp, lines 356-9.
>>>
>>> There’s a pair of strings to break a source line:
>>>      " should match exactly”
>>>      "bottom plus …”
>>> missing a space at the end of the first or beginning of second, else output contains “… exactlybottom …”.
>>>
>>> String literals immediately followed by identifiers, with no intervening spaces, will run afoul of C++11 user-defined literals.  Although gcc and clang provide CLAs to control C++11 features, my understanding is that MS compiler is mostly rolling C++11 features in as implemented in new versions, generally without such controls.  As a result, I would expect such usage to fail to compile on some (possibly still in the future) versions.  Suggest putting spaces between string literals and macro identifiers.
>>>
>>>
>