RFR (XS): JDK-8027450 : Improve time reporting in G1 remark

[Kirk Pepperdine]

Hi Thomas,

The string "[GC remark [GC graph-trace, 0.0095070 secs] [GC ref-proc, 0.0151560 secs] [GC string-unlink, 0.0211210 secs] [GC symbol-unlink, 0.0635730 secs] [GC aggregate-data, 0.0102910 secs], 0.1199190 secs] “ as listed in the web-rev is fine. This is easily machine parseable and it follows the hyphenated format that has been traditionally used in the GC logs.  My only comment is that GC at the beginning of each block is noise but if it makes you happier to have it there... so be it.If this is the output that you can guarantee and it won’t be corrupted by other records and/or flag settings then I think this breakdown will not only be very useful, it will be appreciated.

Kind regards,
Kirk Pepperdine

PS why I prefer the hyphenated output is that it’s easier pick out in cases where output is mixed with other forms of application logging


On Sep 22, 2014, at 6:53 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:

> Hi,
> 
> On Mon, 2014-09-22 at 15:31 +0200, Stefan Karlsson wrote:
>> On 2014-09-22 11:06, Thomas Schatzl wrote:
>>> Hi,
>>> 
>>> On Fri, 2014-09-19 at 11:25 -0400, Joseph Provino wrote:
>>>> Hi all,
>>>> 
>>>> Can I have reviews for the following small change that logs more G1
>>>> Concurrent Mark
>>>> Trace Times.  I also changed G1RemarkGCTraceTime() to G1CMTraceTime()
>>>> because it's
>>>> used in places other than remark.
>>>> 
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8027450
>>>> 
>>>> Webrev:http://cr.openjdk.java.net/~jprovino/8027450/webrev.00/
>>>> 
>>>> Testing: jprt
>>>> 
>>>> I also need a sponsor to commit the changes.
>>> Looks good. Maybe the strings could be changed to fit the existing
>>> though, e.g. "GC ref-proc" -> "Reference processing", and "GC
>>> aggregate-data" -> "Aggregate data".
>> 
>> That might be worth doing, but not as a part of this cleanup. Changing 
>> the log output is usually a much greater undertaking than this small 
>> cleanup.
>> 
> 
> Fine with me.
> 
> Thanks,
>  Thomas
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20140922/45c06336/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20140922/45c06336/signature.asc>