Request for Review (s) - 8133023: ParallelGCThreads is not calculated correctly

Jon Masamitsu jon.masamitsu at oracle.com
Wed Dec 2 17:46:19 UTC 2015



On 11/30/2015 11:47 AM, Kim Barrett wrote:
> On Nov 30, 2015, at 12:20 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>> src/share/vm/runtime/os.cpp
>>>   319   VM_Version::vm_init_before_ergo();
>>>
>>> This call is in generic code, but only two definitions have been
>>> provided, for sparc and x86.  Missing are aarch64, ppc, and zero.
>>>
>> Add vm_init_before_ergo() for those even though JPRT does not
>> build them? I don't need to be convinced to do it.  Just
>> encouraged.  Say "do it" and I'll do it.
> I think you should do it, rather than knowingly breaking the build for those targets when the needed code is so trivial.
>

Here's the webrev for the delta for review comments to this point.

http://cr.openjdk.java.net/~jmasa/8133023/delta.04/

Webrev for complete patch is here.

http://cr.openjdk.java.net/~jmasa/8133023/webrev.04/

Jon



More information about the hotspot-gc-dev mailing list