Request for Review (s) - 8133023: ParallelGCThreads is not calculated correctly

[Kim Barrett]

On Dec 2, 2015, at 12:46 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> 
> 
> 
> On 11/30/2015 11:47 AM, Kim Barrett wrote:
>> On Nov 30, 2015, at 12:20 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>>> src/share/vm/runtime/os.cpp
>>>>  319   VM_Version::vm_init_before_ergo();
>>>> 
>>>> This call is in generic code, but only two definitions have been
>>>> provided, for sparc and x86.  Missing are aarch64, ppc, and zero.
>>>> 
>>> Add vm_init_before_ergo() for those even though JPRT does not
>>> build them? I don't need to be convinced to do it.  Just
>>> encouraged.  Say "do it" and I'll do it.
>> I think you should do it, rather than knowingly breaking the build for those targets when the needed code is so trivial.
>> 
> 
> Here's the webrev for the delta for review comments to this point.
> 
> http://cr.openjdk.java.net/~jmasa/8133023/delta.04/
> 
> Webrev for complete patch is here.
> 
> http://cr.openjdk.java.net/~jmasa/8133023/webrev.04/

Rather than the various platform-specific nop definitions, how about using the same trick used
for VM_Version::early_initialize, e.g. Abstract_VM_Version provides a nop definition, and platforms
that need additional behavior override that definition in their VM_Version definitions.

So here we would have (in runtime/vm_version.hpp)

class Abstract_VM_Version … {
  …

public:
  static void init_before_ergo() { }

  …
};