RFR (M): 8074037: Refactor the G1GCPhaseTime logging to make it easier to add new phases

[Thomas Schatzl]

Hi Mikael,

On Mon, 2015-03-02 at 15:17 +0100, Mikael Gerdin wrote:
> 
> On 2015-03-02 15:05, Thomas Schatzl wrote:
> > Hi,
> >
> > On Fri, 2015-02-27 at 18:43 -0500, Kim Barrett wrote:
> >> On Feb 27, 2015, at 10:38 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
> >>>
> >>> Can I have a couple of reviews for this cleanup change?
> >>>
> >>> http://cr.openjdk.java.net/~brutisso/8074037/webrev.00/
> >>> https://bugs.openjdk.java.net/browse/JDK-8074037
> >>>
[...]
> >
> > I think g1_process_roots() must always claim all tasks, even if the task
> > itself does nothing.
> 
> I'm pretty sure that is incorrect. There is a comment before 
> all_tasks_completed which hints at some verification that all tasks have 
> been claimed but I have never found any code which performs this 
> verification.

Okay, I just went by the comment. Imo it would be nice to actually have
such a verification. I added an RFE.

Thanks,
  Thomas