RFR: 8073464 - GC workers do not have thread names

[David Lindholm]

Hi,

On 2015-03-03 10:36, Bengt Rutisson wrote:
>
> Hi David,
>
> On 2015-03-03 10:02, David Lindholm wrote:
>> Hi,
>>
>> On 2015-02-20 16:01, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On Fri, 2015-02-20 at 14:39 +0100, David Lindholm wrote:
>>>> Hi,
>>>>
>>>> Please review this small fix in GangWorker:initialize(). This addition
>>>> sets the native thread names of GangWorker threads, which the GC uses
>>>> for worker threads. Now these names will be visible when debugging 
>>>> in GDB.
>>>>
>>>> Webrev: 
>>>> http://cr.openjdk.java.net/~stefank/0thers/david/8073464/webrev.00/
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8073464
>>>>
>>>    please use Thread::set_native_thread_name() instead of the os 
>>> function
>>> directly.
>>
>> Ok.
>>
>>> Also, wouldn't it be much more useful to set the native thread name for
>>> all NamedThreads to the name that is passed via set_name() by default?
>>> This would prevent us from doing this work multiple times.
>>
>> Ok, this new patch does this for all NamedThreads.
>>
>>> You might also fix the names themselves for gc owned threads in this 
>>> CR.
>>> I do not see the need to split this up in CRs per thread type with each
>>> CR being a one-line change.
>>
>> The changes of all the thread names will be handled in a separate 
>> change. There is a separate bug for this.
>>
>> I have also changed the copyright year in the changed files, even 
>> though I think it is a weird process to do this separately for every 
>> change.
>
> It is a strange process :)
>
>>
>> New webrev: http://cr.openjdk.java.net/~brutisso/8073464/webrev.01/
>
> Looks good to me.

Thanks for the review!

/David

> Bengt
>
>>
>> I have run and passed JPRT on this change.
>>
>> Thanks,
>> David
>>> Thanks,
>>>    Thomas
>>>
>>
>