RFR (XS): 8073654: Marking statistics should use size_t

Derek White derek.white at oracle.com
Fri Mar 6 18:09:38 UTC 2015


Hi Sangheon,

Looks good to me too. Jesper already asked the only question I had.

  - Derek (drwhite)

On 3/6/15 11:32 AM, Sangheon Kim wrote:
> Hi Jesper,
>
> Thanks for reviewing this.
>
> On 03/06/2015 02:26 AM, Jesper Wilhelmsson wrote:
>> Looks good.
>>
>> Just curious, what motivated the first change, moving the variables 
>> in concurrentMark.cpp?
> I just wanted to have same order as the declaration at the header file.
>
>>
>> Also, your webrevs would be easier to review if you used the latest 
>> version of webrev found here:
>> http://hg.openjdk.java.net/code-tools/webrev
> Oh, I see. Thanks for the pointer.
>
> Sangheon
>
>
>>
>> Thanks,
>> /Jesper
>>
>>
>> Sangheon Kim skrev den 6/3/15 02:23:
>>> Hi all,
>>>
>>> Can I have reviews for this simple fix for changing variables for 
>>> statistics
>>> from 'int' to 'size_t'.
>>> This is to avoid overflows on large heaps.
>>>
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8073654
>>> Webrev:
>>> http://cr.openjdk.java.net/~sangheki/8073654/webrev.00/
>>> Testing:
>>> JPRT
>>>
>>> Thanks,
>>> Sangheon
>




More information about the hotspot-gc-dev mailing list