RFR (S): 8073052: Rename and clean up the allocation manager hierarchy in g1Allocator.?pp

Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 9 11:03:38 UTC 2015


Hi Sangheon,

  thanks for the review. :)

On Thu, 2015-03-05 at 15:55 -0800, Sangheon Kim wrote:
> Hi Thomas,
> 
> On 03/05/2015 06:58 AM, Thomas Schatzl wrote:
> > Hi all,
> >
> > On Wed, 2015-03-04 at
[...]
> >
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8073052/webrev.01
> 
> Change seems good.
> 
> Just minor comments.
> - As Kim already pointed, just curious to have different indentation of 
> access specifiers (protected:, public: ) in our source codes.
> - Copyright year should be updated for 4 files.
>    (g1CollectedHeap_ext.cpp, g1ParScanThreadState.cpp / hpp and 
> heapRegionManager.cpp)

I removed all whitespace changes in visibility specifiers and updated
the copyrights.

There is a new webrev at
http://cr.openjdk.java.net/~tschatzl/8073052/webrev.2 (full)
http://cr.openjdk.java.net/~tschatzl/8073052/webrev.1_to_2 (diff)

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list