Request for review (XXS) : 8067891 Remove vestigal G1SATBCT barrier set kind

Joseph Provino joseph.provino at oracle.com
Tue Mar 10 20:19:32 UTC 2015


Indeed my repo was out of date.

New webrev is here: http://cr.openjdk.java.net/~jprovino/8067891/webrev.02/

resubmitting to jprt now.

thanks.

joe

On 3/10/2015 4:00 PM, Kim Barrett wrote:
> On Mar 10, 2015, at 3:15 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8067891
>> Remove vestigal G1SATBCT barrier set kind
>>
>> G1SATBCT still needs to be defined but there is no concrete class
>> which uses it.  This means that all instances of
>>
>> "case BarrierSet::G1SATBCT"
>>
>> can be removed which is what this change does.
>>
>> Tested with JPRT.
>>
>> Webrev:  http://cr.openjdk.java.net/~jprovino/8067891/webrev.01
>>
>> I will need someone to commit the changes for me.
>>
>> thanks.
>>
>> joe
>
> Looks like you missed these:
>
> ./src/cpu/aarch64/vm/templateTable_aarch64.cpp:    case BarrierSet::G1SATBCT:
> ./src/cpu/aarch64/vm/stubGenerator_aarch64.cpp:    case BarrierSet::G1SATBCT:
> ./src/cpu/aarch64/vm/stubGenerator_aarch64.cpp:      case BarrierSet::G1SATBCT:
>
> Presumably your local repo is a little out of date.
>




More information about the hotspot-gc-dev mailing list