RFR (M) 8075210: Refactor strong root processing in order to allow G1 to evolve separately from GenCollectedHeap

[Mikael Gerdin]

Hi Thomas,

On 2015-03-18 13:32, Thomas Schatzl wrote:
> Hi again,
>
> On Wed, 2015-03-18 at 13:28 +0100, Thomas Schatzl wrote:
>> Hi Mikael,
>>
>> On Tue, 2015-03-17 at 17:00 +0100, Mikael Gerdin wrote:
>>> On 2015-03-17 15:26, Thomas Schatzl wrote:
>>>> Hi Mikael,
>> [...]
>>>>
>>>> - I think the instantiation of G1RootsProcessor in
>>>> G1CollectedHeap::verify() should be scoped, i.e. it and the call to
>>>> process_all_roots() enclosed with braces.
>>>
>>> Fixed.
>>>
>>
>> Wrong indentation of the &blobsl parameter. I do not need to re-review
>> that.

Yep, fixed already.

>>
>> [...]
>>>
>>> Here's an incremental webrev incorporating your suggestions:
>>> http://cr.openjdk.java.net/~mgerdin/8075210/thomas-comments/webrev/
>>> It's based on
>>> http://cr.openjdk.java.net/~mgerdin/8075210/done_with_threads/webrev/
>>> which incorporates Eric's renaming request.
>>>
>>> New full webrev at:
>>> http://cr.openjdk.java.net/~mgerdin/8075210/full2/webrev/
>>
>> Looks good.
>
>
> Some last-minute comment if it is not still too late:
>
> - G1CollectedHeap::set_par_threads(uint t) can be removed. It only calls
> the inherited method anyway.

Right, removed it.

Final full webrev at
http://cr.openjdk.java.net/~mgerdin/8075210/full3/webrev/
I didn't create an incremental for the removal of 
G1CollectedHeap::set_par_threads(uint t), I hope that's ok.

You need to look at the sdiff to see the blobsCl alignment:
http://cr.openjdk.java.net/~mgerdin/8075210/full3/webrev/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp.sdiff.html 


/Mikael

>
> Thanks,
>    Thomas
>
>