[8u60] RFR backport of 8069273: Decrease Hot Card Cache Lock contention

Mikael Gerdin mikael.gerdin at oracle.com
Thu Mar 26 08:28:18 UTC 2015


Hi Thomas,

On 2015-03-25 16:22, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for the backport of "8069273: Decrease Hot Card
> Cache Lock contention" for 8u60?
>
> It did only apply with minor changes, so I need re-reviews. The problems
> are:
> - some previous, non-ported changed the copyright date
> - 8u60 does not have size_t versions of the Atomic instructions, fixed
> by casting to intptr_t (as done elsewhere in this case)
> - removing the HotCardCache_lock needed to be done manually, as
> somewhere the declaration order of locks changed in mutexLocker.cpp.
>
> Note that this change is based on "JDK-8053998: Hot card cache flush
> chunk size too coarse grained", which is also out for review.
>
> Full 8u60 changeset:
> http://cr.openjdk.java.net/~tschatzl/8069273-8u60/webrev.8u60/
> Diff changest:
> http://cr.openjdk.java.net/~tschatzl/8069273-8u60/webrev.8u60-fix/

Looks good.
/Mikael

>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8069273
>
> Original change:
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/1c8ba2d0d2f0
>
> Testing: jprt
>
> Thanks,
>    Thomas
>
>




More information about the hotspot-gc-dev mailing list