RFR (S): JDK-8076076: Move SharedHeap::print_size_transition() into G1 code

Bengt Rutisson bengt.rutisson at oracle.com
Thu Mar 26 13:30:42 UTC 2015


Hi everyone,

One more step towards eventually getting rid of SharedHeap.

Could I have a couple of reviews for this small change:

http://cr.openjdk.java.net/~brutisso/8076076/webrev.00/

https://bugs.openjdk.java.net/browse/JDK-8076076

The method SharedHeap::print_size_transition() is only used by G1 but 
was placed in SharedHeap. It was called from the G1CollectorPolicy 
class, so I moved it to be next to the other related methods 
(G1CollectorPolicy::print_heap_transition() and 
G1CollectorPolicy::print_detailed_heap_transition()). I also renamed it 
to print_heap_transition() to be more consistent with the other two 
methods. Some simplifications to the parameter list could be made now 
that it is an internal G1 method.

Thanks,
Bengt




More information about the hotspot-gc-dev mailing list