RFR(xs): JDK-8076173: VirtualSpaceNode container_count() and container_count_slow() have different return types
Stefan Karlsson
stefan.karlsson at oracle.com
Tue Mar 31 09:28:17 UTC 2015
On 2015-03-31 11:26, David Lindholm wrote:
> Thanks,
>
> I did a little further cleanup by letting inc_container_count() call
> verify_container_count() instead of having its own copy of the same
> assert.
>
> http://cr.openjdk.java.net/~david/JDK-8076173/webrev.02/
Looks good.
StefanK
>
>
> /David
>
> On 2015-03-31 11:17, Stefan Karlsson wrote:
>> On 2015-03-31 10:50, David Lindholm wrote:
>>> Hi,
>>>
>>> Ok. New webrev at
>>> http://cr.openjdk.java.net/~david/JDK-8076173/webrev.01/
>>
>> Looks good.
>>
>> StefanK
>>
>>>
>>>
>>> /David
>>>
>>> On 2015-03-31 10:31, Per Liden wrote:
>>>> On 2015-03-31 10:20, David Lindholm wrote:
>>>>> Hi,
>>>>>
>>>>> Please review this small patch that makes container_count_slow()
>>>>> use the
>>>>> same return type as container_count().
>>>>>
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8076173/webrev.00/
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076173
>>>>
>>>> Change looks good. But while you're at it, could you please also
>>>> change so that we're using UINTX_FORMAT instead of SIZE_FORMAT when
>>>> we're printing those?
>>>>
>>>> /Per
>>>
>>
>
More information about the hotspot-gc-dev
mailing list