RFR (S): 8138750: Clean up survivor rate group

Thomas Schatzl thomas.schatzl at oracle.com
Wed Oct 14 11:33:57 UTC 2015


Hi,

On Mon, 2015-10-05 at 16:29 +0200, Mikael Gerdin wrote:
> Hi Thomas,
[...]
> >    return _last_young_gc && !_in_marking_code;
> 
> This should be !_in_marking_window I suppose.
> 
> >
> > which has been introduced in JDK-7097567. It should actually be:
> >
> >    return _last_gc_was_young && !_in_marking_window;
> >
> > I will fix that in JDK-8138752 to keep the cleanup separate from the bug
> > fix unless someone objects.
> 
> Splitting the change up sounds good to me.
> 
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8138750
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8138750/webrev
> 
> Looks good.
> /Mikael

  thanks for the review.

Thomas





More information about the hotspot-gc-dev mailing list