RFR (S): 8138750: Clean up survivor rate group

Thomas Schatzl thomas.schatzl at oracle.com
Wed Oct 14 11:35:30 UTC 2015


Hi,

On Tue, 2015-10-06 at 17:21 -0400, Tom Benson wrote:
> Hi Thomas,
> Cleanup looks fine to me, too.  Just one comment you can choose whether 
> to ignore:   it seems like the one-line body of 
> should_update_surv_rate_group_predictors could just as easily be inline 
> when the only use is  "bool update = should_update...... ", now in the 
> same module.  Unless you envision other uses.
> Tom

In this case I prefer the method as it is much more understandable in
the context of the method than the "complicated" actual term.

  thanks for the review.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list