RFR: 8140508: Add utility method for logging phases to G1CollectorPolicy

Mikael Gerdin mikael.gerdin at oracle.com
Wed Oct 28 14:01:08 UTC 2015


Erik,

On 2015-10-28 14:58, Erik Helin wrote:
> All,
>
> small update based on offline discussion between me and Thomas:
> - make G1GCPhaseTimes::note_gc_end private and call it from
>    G1GCPhaseTimes::print. note_gc_end must always be called before print,
>    so it makes sense to just call it from print.
> - Rename G1CollectorPolicy::log_phases to
>    G1CollectorPolicy::print_phases, since "print" is more frequently used
>    than "log" in the G1 code.
>
> Please see new webrev:
> http://cr.openjdk.java.net/~ehelin/8140508/webrev.01/

Still ok to me.
/Mikael

>
> Thanks,
> Erik
>
> On 2015-10-27, Erik Helin wrote:
>> Hi all,
>>
>> this small patch just adds a small utility method to G1CollectorPolicy,
>> log_phases.
>>
>> Enhancement:
>> https://bugs.openjdk.java.net/browse/JDK-8140508
>>
>> Webrev:
>> http://cr.openjdk.java.net/~ehelin/8140508/webrev.00/
>>
>> Testing:
>> JPRT
>>
>> Thanks,
>> Erik




More information about the hotspot-gc-dev mailing list