RFR: 8140508: Add utility method for logging phases to G1CollectorPolicy

Thomas Schatzl thomas.schatzl at oracle.com
Thu Oct 29 10:19:07 UTC 2015


Hi,

On Wed, 2015-10-28 at 14:58 +0100, Erik Helin wrote:
> All,
> 
> small update based on offline discussion between me and Thomas:
> - make G1GCPhaseTimes::note_gc_end private and call it from
>   G1GCPhaseTimes::print. note_gc_end must always be called before print,
>   so it makes sense to just call it from print.
> - Rename G1CollectorPolicy::log_phases to
>   G1CollectorPolicy::print_phases, since "print" is more frequently used
>   than "log" in the G1 code.
> 
> Please see new webrev:
> http://cr.openjdk.java.net/~ehelin/8140508/webrev.01/
> 

  looks good.

Thomas




More information about the hotspot-gc-dev mailing list